Re: [PATCHES] snprintf() argument reordering not working

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <ntufar(at)gmail(dot)com>, <devrim(at)kivi(dot)com(dot)tr>, <mha(at)sollentuna(dot)net>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] snprintf() argument reordering not working
Date: 2005-12-05 07:02:30
Message-ID: 1730.24.211.165.134.1133766150.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian said:
>
> OK, a few things. First, Tom has fixed snprintf.c so it should
> properly process positional parameters now. Would you first test the
> libintl version of *printf to see if it can process %$ parameters
> (probably by hacking up any language file and testing the printing),
> and then try your patch below to see if it is properly reorders the
> arguments. If libintl does not reorder properly, but our snprintf.c
> does, would you please generate an appliable patch we can put into
> 8.1.X? Thanks.
>
> I know I am asking a lot, but you are "the man" on this one. :-)
>

Since the effect of the configure change I am proposing to reverse was to
force use of the *printf in libintl, don't we already know the answer to
your first question from Nicolai's report?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2005-12-05 08:28:39 Re: generalizing the planner knobs
Previous Message Greg Stark 2005-12-05 06:53:55 Re: generalizing the planner knobs

Browse pgsql-patches by date

  From Date Subject
Next Message Kris Jurka 2005-12-05 08:35:10 Re: date overflows
Previous Message Tom Lane 2005-12-05 05:25:33 Re: port/snprintf.c (was Re: Numeric 508 datatype)