| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: language cleanups in code and docs |
| Date: | 2020-06-17 13:32:55 |
| Message-ID: | 172c908a-17f4-59e0-446f-a6f2e1217e14@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/17/20 6:32 AM, Magnus Hagander wrote:
> In looking at this I realize we also have exactly one thing referred to
> as "blacklist" in our codebase, which is the "enum blacklist" (and then
> a small internal variable in pgindent). AFAICT, it's not actually
> exposed to userspace anywhere, so we could probably make the attached
> change to blocklist at no "cost" (the only thing changed is the name of
> the hash table, and we definitely change things like that in normal
> releases with no specific thought on backwards compat).
+1. Though if we are doing that, we should also handle "whitelist" too,
as this attached patch does. It's mostly in comments (with one Perl
variable), but I switched the language around to use "allowed"
Jonathan
| Attachment | Content-Type | Size |
|---|---|---|
| allowed.patch | text/plain | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2020-06-17 13:36:58 | Re: language cleanups in code and docs |
| Previous Message | Amit Kapila | 2020-06-17 13:02:12 | Re: [Patch] ALTER SYSTEM READ ONLY |