Re: fix for windows breakage in regression script

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix for windows breakage in regression script
Date: 2005-01-15 04:54:46
Message-ID: 1729.24.211.141.25.1105764886.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane said:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Tom Lane wrote:
>>> Hm --- have you checked it since I changed the script?
>
>> yes. See
>> http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=gibbon&br=HEAD
>
> [ scratches head... ] Why isn't the #undef in pg_config_manual.h
> firing on Cygwin?

The lines say:

#if defined(__QNX__) || defined(__BEOS__) || defined(WIN32)
#undef HAVE_UNIX_SOCKETS
#endif

But on Cygwin, WIN32 is only defined if windows.h has been included (See
previous discussion - I recall advocating NOT using WIN32 as a marker for
just this reason).

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-01-15 06:01:50 Re: fix for windows breakage in regression script
Previous Message Tom Lane 2005-01-15 04:19:22 Re: fix for windows breakage in regression script