Re: GUC time unit spelling a bit inconsistent

Andrew Sullivan <ajs(at)crankycanuck(dot)ca> writes:
> Nevertheless, I think that Tom's original suggestion was at least a
> HINT, which seems perfectly reasonable to me.

That's the only idea in the whole thread that hasn't been objected to,
so let's just do that and have done with it. (Even if we were to agree
on loosening the accepted set of unit names, a HINT listing the accepted
names would still be needed.)

I gather Peter is travelling, so I'll take a cut at a patch. I'm
imagining that the output will look something like

ERROR: invalid value for parameter "autovacuum_naptime": "5sec"
HINT: Valid units for this parameter are "d", "h", "min", "s", "ms".

where the HINT gets appended if there's something after the integer but
it doesn't look like any of the allowed units. Objections?

regards, tom lane