Re: Remove unnecessary grammar symbols

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unnecessary grammar symbols
Date: 2020-12-03 15:07:12
Message-ID: 1722771.1607008032@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> While doing the proverbial other things, I noticed that the grammar
> symbols publication_name_list and publication_name_item are pretty
> useless. We already use name_list/name to refer to publications in most
> places, so getting rid of these makes things more consistent.

+1. Strictly speaking, this reduces the set of keywords that you
can use as names here (since name is ColId, versus ColLabel in
publication_name_item). However, given the inconsistency with
other commands, I don't see it as an advantage to be more forgiving
in just one place. We might have problems preserving the laxer
definition anyway, if the syntaxes of these commands ever get
any more complicated.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-12-03 15:15:46 Re: Corner-case bug in pg_rewind
Previous Message Andrew Dunstan 2020-12-03 14:57:31 Re: Github Actions (CI)