| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Douglas Doole <dougdoole(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Push limit to sort through a subquery |
| Date: | 2017-08-25 14:05:46 |
| Message-ID: | 17216.1503669946@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I'm inclined to commit both of these after a little more testing and
> self-review, but let me know if anyone else wants to review first.
Looking through the first one, I wondered whether we needed to
check for a qual expression on Gather or GatherMerge. It seems like
it would be stupid to put a filter on that node rather than its
children, but I see this in both nodeGather.c and nodeGatherMerge.c:
/*
* initialize child expressions
*/
gatherstate->ps.qual =
ExecInitQual(node->plan.qual, (PlanState *) gatherstate);
It doesn't look like the qual is actually used anywhere in either node
type. Am I right in thinking this is dead code?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2017-08-25 14:05:55 | Re: ECPG: WHENEVER statement with DO CONTINUE action |
| Previous Message | Magnus Hagander | 2017-08-25 14:03:37 | Re: Not listed as committer |