From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] GnuTLS support |
Date: | 2018-01-19 22:16:50 |
Message-ID: | 1719CF5C-6350-41C6-84E7-83403AE8BECA@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 19 Jan 2018, at 19:43, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> 0003-Move-EDH-support-to-common-files.patch
>
> To avoid copy-and-paste, and also because the EDH explanation doesn't
> really belong in a file header comment. Maybe the whole thing is known
> well enough nowadays that we can just remove the explanation.
Perhaps, I still think it’s a good idea to keep it in README.SSL
> 0004-Move-SSL-API-comments-to-header-files.patch
> 0005-Extract-common-bits-from-OpenSSL-implementation.patch
>
> Move copy-and-paste avoidance.
+1 on doing this type of refactoring before anything else lands, when
implementing ST the excessive copy-paste was annoying (but avoided for
scope-creep).
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2018-01-19 22:19:41 | Re: Logical Decoding and HeapTupleSatisfiesVacuum assumptions |
Previous Message | Tomas Vondra | 2018-01-19 22:08:02 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |