Re: logical replication of truncate command with trigger causes Assert

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Wed, Jun 9, 2021 at 8:44 PM Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>> On Jun 9, 2021, at 7:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Somewhat unrelated, but ... am I reading the code correctly that
>>> apply_handle_stream_start and related routines are using Asserts
>>> to check that the remote sent stream-control messages in the correct
>>> order?

> This also needs to be changed to test-and-elog.

Here's a proposed patch for this. It looks like pretty much all of the
bogosity is new with the streaming business. You might quibble with
which things I thought deserved elog versus ereport. Another thing
I'm wondering is how many of these messages really need to be
translated. We could use errmsg_internal and avoid burdening the
translators, perhaps.

regards, tom lane