Re: Bug in StartupSUBTRANS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in StartupSUBTRANS
Date: 2016-02-09 18:45:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Your patch looks right to me, so I will commit, barring objections... with
> backpatch. Likely to 9.0, AFAICS.

9.0 is out of support and should not be patched anymore.

I agree that the patch is basically correct, though I'd personally
write it without bothering with the extra variable:

+ /* must account for wraparound */
+ if (startPage > TransactionIdToPage(0xFFFFFFFF))
+ startPage = 0;

Also, the comment at line 45 is now wrong and needs an addition.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-02-09 19:10:50 Re: Tracing down buildfarm "postmaster does not shut down" failures
Previous Message Simon Riggs 2016-02-09 18:33:00 Re: Bug in StartupSUBTRANS