Re: pgsql: Minor pg_dump improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Minor pg_dump improvements
Date: 2014-02-09 18:03:52
Message-ID: 17153.1391969032@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> I'm pretty sure you broke _CloseArchive with this hunk:

> That'd be pretty frustrating as my testing didn't exhibit any issues.

It's possible that errno is accidentally zero when we get there, but
the code as-committed surely can't be called bulletproof.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2014-02-09 18:31:20 pgsql: Focus on ftello result < 0 instead of errno
Previous Message Stephen Frost 2014-02-09 17:54:14 Re: pgsql: Minor pg_dump improvements