Re: Fix for erroneous warning on Shutdown

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for erroneous warning on Shutdown
Date: 2004-06-11 18:25:48
Message-ID: 17149.1086978348@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> Minor patch to correct erroneous warning in cvs tip, believed to be a
> very minor regression.

This patch is wrong; it effectively disables the warning altogether.

> When a shutdown was requested within CHECKPOINT_SECONDS of a checkpoint,
> the shutdown code in the bgwriter (which has does checkpointing) would
> issue the erroneous message:

I don't think so ... the shutdown path doesn't go through this code.
Could you take another look at the cause of what you saw?

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-06-11 18:36:40 Re: Fix for erroneous warning on Shutdown
Previous Message Bruce Momjian 2004-06-11 18:17:25 Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-11 18:36:40 Re: Fix for erroneous warning on Shutdown
Previous Message Bruce Momjian 2004-06-11 18:25:03 Re: [PATCHES] serverlog function (log_destination file)