| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add Nullif case for eval_const_expressions_mutator |
| Date: | 2021-04-02 09:08:34 |
| Message-ID: | 170e5c7f-6f78-7aa6-1797-5e429e9b972d@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30.03.21 11:20, Peter Eisentraut wrote:
> On 24.03.21 11:52, houzj(dot)fnst(at)fujitsu(dot)com wrote:
>>> + if (!has_nonconst_input)
>>> + return ece_evaluate_expr(expr);
>>>
>>> That's not okay without a further check to see if the comparison
>>> function used
>>> by the node is immutable. Compare ScalarArrayOpExpr, for instance.
>>
>> Thanks for pointing it out.
>> Attaching new patch with this change.
>
> This patch looks okay to me and addresses all the feedback that was
> given. If there are no more comments, I'll commit it in a few days.
done
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinya11.Kato | 2021-04-02 09:19:32 | RE: Fix pg_checksums progress report |
| Previous Message | Fujii Masao | 2021-04-02 09:03:21 | Re: Fix pg_checksums progress report |