| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: idea: custom log_line_prefix components besides application_name |
| Date: | 2017-05-09 19:24:21 |
| Message-ID: | 17068.1494357861@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Fetter <david(at)fetter(dot)org> writes:
> On Tue, May 09, 2017 at 12:48:01PM -0400, Tom Lane wrote:
>> I don't think that's a problem: while psql will remove "--" and everything
>> following it until newline, it won't remove the newline. So there's still
>> a token boundary there.
> We may still need to be careful.
> davidfetter(at)davidfetter=# SELECT 'foo'-- stuff goes here
> 'bar';
> ?column?
> ----------
> foobar
> (1 row)
If you read the SQL spec, you'll find that particular behavior is
required by spec, and would still be required by spec with or
without the comment. Perhaps it's a trap for unwary SQL programmers,
but psql isn't making it worse.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Serge Rielau | 2017-05-09 19:29:31 | Re: CTE inlining |
| Previous Message | Peter Eisentraut | 2017-05-09 19:23:03 | Re: proposal psql \gdesc |