| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Column Filtering in Logical Replication |
| Date: | 2022-03-26 21:37:14 |
| Message-ID: | 170549.1648330634@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> I went over the patch again, polished the commit message a bit, and
> pushed. May the buildfarm be merciful!
Initial results aren't that great. komodoensis[1], petalura[2],
and snapper[3] have all shown variants of
# Failed test 'partitions with different replica identities not replicated correctly'
# at t/031_column_list.pl line 734.
# got: '2|4|
# 4|9|'
# expected: '1||5
# 2|4|
# 3||8
# 4|9|'
# Looks like you failed 1 test of 34.
[18:19:36] t/031_column_list.pl ...............
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/34 subtests
snapper reported different actual output than the other two:
# got: '1||5
# 3||8'
The failure seems intermittent, as both komodoensis and petalura
have also passed cleanly since the commit (snapper's only run once).
This smells like an uninitialized-variable problem, but I've had
no luck finding any problem under valgrind. Not sure how to progress
from here.
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=komodoensis&dt=2022-03-26%2015%3A54%3A04
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2022-03-26%2004%3A20%3A04
[3] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=snapper&dt=2022-03-26%2018%3A46%3A28
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-26 21:41:53 | Re: pg_stat_get_replication_slot() marked not strict, crashes |
| Previous Message | Andres Freund | 2022-03-26 21:26:29 | Re: More weird compiler warnings |