From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
Cc: | Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Allow declaration after statement and reformat code to use it |
Date: | 2021-08-19 14:34:04 |
Message-ID: | 1703760.1629383644@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> Em qui., 19 de ago. de 2021 às 08:50, Jelte Fennema <
> Jelte(dot)Fennema(at)microsoft(dot)com> escreveu:
>> ## Why would we want this?
>> 1. It removes 23328 lines of code that don't have any impact on how the
>> code behaves [1]. This is roughly 2.7% of all the lines of code in the
>> codebase.
> C needs readability, not fewer lines.
> Aside from horrible code, it doesn't improve 0.1% on anything.
> I think it's a bad idea and I'm strongly against it.
Same here. We have thirty-ish years worth of coding habits developed
around the existing C90-based layout rules. I really doubt that a
quasi-mechanical transformation is going to result in better code style.
What it certainly will do, though, is create a pile of hazards for
back-patching.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2021-08-19 14:50:10 | Re: Proposal: More structured logging |
Previous Message | Magnus Hagander | 2021-08-19 14:14:25 | Re: Proposal: More structured logging |