Re: Column Filtering in Logical Replication

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Subject: Re: Column Filtering in Logical Replication
Date: 2022-03-13 21:07:49
Message-ID: 16e83ce3-8415-b732-37b2-c3329a2c13a1@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/12/22 05:30, Amit Kapila wrote:
>> ...
>
> Okay, please find attached. I have done basic testing of this, if we
> agree with this approach then this will require some more testing.
>

Thanks, the proposed changes seem like a clear improvement, so I've
added them, with some minor tweaks (mostly to comments).

I've also included the memory context rename (entry_changes to the
change proposed by Wang Wei, using a single SQL command in tablesync.

And I've renamed the per-entry memory context to entry_cxt, and used it
for the column list.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-fixup-publish_as_relid-20220313.patch text/x-patch 6.4 KB
0002-fixup-row-filter-publications-20220313.patch text/x-patch 2.1 KB
0003-Allow-specifying-column-filters-for-logical-20220313.patch text/x-patch 165.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-03-13 21:22:00 Re: SQL/JSON: JSON_TABLE
Previous Message Melanie Plageman 2022-03-13 17:05:27 Re: Issue with pg_stat_subscription_stats