| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should pg_current_wal_location() become pg_current_wal_lsn() |
| Date: | 2017-05-09 03:35:34 |
| Message-ID: | 16b61d59-8974-9110-8989-b73c7acdf498@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/1/17 08:10, David Rowley wrote:
> On 20 April 2017 at 07:29, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
>> 2017-04-19 1:32 GMT-03:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:
>>>
>>> I vote for "location" -> "lsn". I would expect complains about the
>>> current inconsistency at some point, and the function names have been
>>> already changed for this release..
>
> OK, so I've created a draft patch which does this.
After reading this patch, I see that
a) The scope of the compatibility break is expanded significantly beyond
what was already affected by the xlog->wal renaming.
b) Generally, things read less nicely and look more complicated.
So I still think we'd be better off leaving things the way they are.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-05-09 05:07:53 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
| Previous Message | Peter Eisentraut | 2017-05-09 03:23:34 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |