From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: null iv parameter passed to combo_init() |
Date: | 2022-01-09 16:51:16 |
Message-ID: | 1693542.1641747076@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Sun, Jan 09, 2022 at 04:37:32AM -0800, Zhihong Yu wrote:
>> On Sat, Jan 8, 2022 at 11:32 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> FWIW, I liked the "ivlen > 0" formulation better. They should be
>>> equivalent, because ivlen is unsigned, but it just seems like "> 0"
>>> is more natural.
> If I were considering the one code site in isolation, I'd pick "ivlen > 0".
> But of the four sites identified so far, three have signed length variables.
Oh, hmm. Unless we want to start changing those to unsigned, I agree
a not-equal test is a safer convention.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2022-01-09 18:09:03 | Re: Non-superuser subscription owners |
Previous Message | Tom Lane | 2022-01-09 16:49:30 | Re: Why is src/test/modules/committs/t/002_standby.pl flaky? |