From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | t-ishii(at)sra(dot)co(dot)jp |
Cc: | "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>, "Bruce Momjian" <maillist(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] md.c is feeling much better now, thank you |
Date: | 1999-09-06 14:12:42 |
Message-ID: | 16914.936627162@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
>> Hmm. It seems a more straightforward solution would be to alter
>> pg_parse_and_plan so that the parser isn't even called if we have
>> already failed the current transaction; that is, the "queries ignored"
>> test should occur sooner. I'm rather surprised to realize that
>> we do run the parser in this situation...
> No. we have to run the parser so that we could accept "end".
Ah, very good point. I stand corrected.
>>>> Until that I propose following solution. It looks
>>>> simple, safe and would be neccessary anyway (I don't know why that
>>>> check had not been implemented). See included patches.
>>
>> This looks like it might be a good change, but I'm not quite as sure
>> as you are that it won't have any bad effects. Have you tested it?
>
> At least initdb and the regression test runs fine for me...
Same here. I have committed it into current, but not REL6_5.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 1999-09-06 14:14:12 | Re: [HACKERS] DROP TABLE inside transaction block |
Previous Message | Leon | 1999-09-06 11:51:46 | Re: [HACKERS] DROP TABLE inside transaction block |