Re: Allow COMMENT ON to accept an expression rather than just a string

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Abhijit Menon-Sen <ams(at)oryx(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow COMMENT ON to accept an expression rather than just a string
Date: 2009-04-11 14:07:51
Message-ID: 16856.1239458871@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Abhijit Menon-Sen <ams(at)oryx(dot)com> writes:
> There's a TODO item about making COMMENT ON accept an expression. The
> grammar change is simple (SConst|NULL_P->a_expr), but as far as I can
> see, there are no similar utility commands that take expressions, and
> I'm not very familiar with the planner and executor, so I could use
> some advice about how to evaluate the expression.

There aren't *any* utility commands that take expressions, and I would
say that that TODO item is seriously mis-scoped. What is the use of
making COMMENT in particular do this? Fixing all of them might be
interesting.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-04-11 14:25:53 pg_dumpall --clean is completely broken
Previous Message Hitoshi Harada 2009-04-11 13:27:28 Re: Closing some 8.4 open items