From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | More #ifdef fun: src/interfaces/libpq/win32.c |
Date: | 2006-07-15 15:59:28 |
Message-ID: | 16856.1152979168@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
src/interfaces/libpq/win32.c contains
/* Declared here to avoid pulling in all includes, which causes name collissions */
#ifdef ENABLE_NLS
extern char *
libpq_gettext(const char *msgid)
__attribute__((format_arg(1)));
#else
#define libpq_gettext(x) (x)
#endif
Now, since it has nowhere bothered to #include pg_config.h, ENABLE_NLS
will certainly not be defined, and so this code always fails to invoke
gettext.
This may not be real important since the file appears to use gettext
only here:
if (!success)
sprintf(strerrbuf, libpq_gettext("Unknown socket error (0x%08X/%i)"), err, err);
but it's still pretty bogus.
Without a Windows machine, I'm not in a position to try making this file
properly include postgres_fe.h, or at least c.h, but someone ought to
try harder.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Sergey E. Koposov | 2006-07-15 16:12:58 | PG_RETURN_INT64 vs PointerGetDatum & ANALYZE |
Previous Message | Tom Lane | 2006-07-15 15:28:42 | Re: [PATCHES] [patch 0/9] annual pgcrypto update |
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2006-07-15 23:42:50 | Have psql display names and OUT/INOUT in \df output |
Previous Message | Tom Lane | 2006-07-15 15:28:42 | Re: [PATCHES] [patch 0/9] annual pgcrypto update |