From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | "Jason O'Donnell" <odonnelljp01(at)gmail(dot)com>, pgsql-docs(at)postgresql(dot)org |
Subject: | Re: Example error in createdb doc |
Date: | 2016-11-22 23:17:35 |
Message-ID: | 16840.1479856655@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Oct 27, 2016 at 09:01:59PM -0400, Jason O'Donnell wrote:
>> The example given for createdb fails because template0 is not provided:
> I have looked over this report and patch, and it just doesn't feel
> right. The example is intending to show how to use common psql-like
> options to control createdb. Adding the encoding is nice, but then
> having to switch to template0 so the encoding setting works just seems
> beyond the scope of what we want do there.
> I think the attached patch is more focused.
I dunno. The use of -e seems pretty pointless for a call that is going to
yield a trivial CREATE DATABASE command. Besides, we already showed a
minimal example. If you think Jason's example is too complex, what about
just subbing in "-T template0" for "-E LATIN1"? That should work
regardless of other configuration.
Also, your change to the text loses the point that -e provokes printing
the underlying command. Admittedly, that was somewhat indirect in the way
it was phrased before, but now the concept is just gone entirely; that
doesn't feel like an improvement either.
Personally I thought Jason's patch was fine as-is.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-11-23 02:39:47 | Re: [HACKERS] switching documentation build to XSLT |
Previous Message | Bruce Momjian | 2016-11-22 22:31:44 | Re: Example error in createdb doc |