Re: Patch to install config/missing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to install config/missing
Date: 2015-11-11 19:24:33
Message-ID: 16839.1447269873@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 11/11/2015 12:34 PM, Tom Lane wrote:
>> I was thinking more of removing the "missing" script and associated logic
>> entirely, rather than making PGXS a special case. I think we should do
>> our best to minimize differences between behaviors in core builds and
>> PGXS builds, if only because we don't test the latter very much and
>> might not notice problems there.

> At least two buildfarm members (crake and sitella) build FDWs using
> PGXS. Of course, they aren't likely to uncover problems with missing
> perl/bison/flex - especially perl ;-) But I don't want people to get the
> idea we don't test PGXS regularly, because we do.

I know we have buildfarm coverage, but by its nature that's not going to
exercise scenarios like missing tools. You only find out about problems
of that ilk from manual testing in non-controlled environments. And
I think we have much more of that going on for the core build than for
any add-on.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-11-11 19:26:56 Re: Parallel Seq Scan
Previous Message Peter Eisentraut 2015-11-11 19:13:03 Re: Proposal: "Causal reads" mode for load balancing reads without stale data