Re: Add RISC-V Zbb popcount optimization

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Greg Burd" <greg(at)burd(dot)me>
Cc: "Andres Freund" <andres(at)anarazel(dot)de>, "Nathan Bossart" <nathandbossart(at)gmail(dot)com>, "John Naylor" <johncnaylorls(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Subject: Re: Add RISC-V Zbb popcount optimization
Date: 2026-05-29 16:23:11
Message-ID: 1682854.1780071791@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Greg Burd" <greg(at)burd(dot)me> writes:
> The zic.c hit is the one that bothers me. It's the same shape as des_init() --
> byte-sized destination, scatter store via an indexing array -- and it's not
> exercised by `make check`, since zic runs at `make install` to compile the IANA
> tz data.

"make check" certainly *will* run zic.c, while creating the temporary
installation. (Unless you use --with-system-tzdata, which I'm sure
most production builds do.) But our test suite touches only a very
tiny fraction of the tzdata files, so even if there's some
corruption in them we wouldn't necessarily notice it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2026-05-29 16:25:10 Re: Seeking Guidance on Fixing the Cyclic RLS Policy / Infinite Recursion Bug in PostgreSQL
Previous Message Laurenz Albe 2026-05-29 16:20:19 Re: Key joins