From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] random_normal function |
Date: | 2023-01-03 02:38:28 |
Message-ID: | 1682143.1672713508@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> FYI, here is the failure:
> [21:23:10.814] In file included from pg_prng.c:27:
> [21:23:10.814] ../../src/include/utils/float.h:46:16: error: ‘struct
> Node’ declared inside parameter list will not be visible outside of
> this definition or declaration [-Werror]
> [21:23:10.814] 46 | struct Node *escontext);
Hmm ... this looks an awful lot like it is the fault of ccff2d20e
not of the random_normal patch; that is, we probably need a
"struct Node" stub declaration in float.h. However, why are we
not seeing any reports of this from elsewhere? I'm concerned now
that there are more places also needing stub declarations, but
my test process didn't expose it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-01-03 02:46:43 | Re: CFM for 2023-01 |
Previous Message | Jeff Davis | 2023-01-03 02:26:13 | Re: New strategies for freezing, advancing relfrozenxid early |