From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Eugene Kazakov <e(dot)kazakov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Small PATCH: check of 2 Perl modules |
Date: | 2016-02-15 15:02:12 |
Message-ID: | 16821.1455548532@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
>> On 2/12/16 8:20 AM, Eugene Kazakov wrote:
>>> TAP-tests need two Perl modules: Test::More and IPC::Run.
>> I think those modules are part of a standard Perl installation.
> IPC::Run is not. At least for perl from ports tree in FreeBSD.
Yeah, I remember having had to install IPC::Run from CPAN, and a couple
of other things too (but I don't remember Test::More specifically), when
setting up some of my buildfarm critters. It's likely that a lot of
distros bundle these, but I don't think IPC::Run is in a basic
built-from-source Perl.
The real question though is do we need a configure check at all.
Given that investigation into a CMake conversion is actively going
on, I'm hesitant to move the goalposts for it by introducing a brand
new type of configure check. Maybe we should punt this issue until
that patch is either accepted or decisively rejected.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2016-02-15 15:29:13 | Re: [PATCH] we have added support for box type in SP-GiST index |
Previous Message | Tom Lane | 2016-02-15 14:55:24 | Re: [WIP] ALTER ... OWNER TO ... CASCADE |