Re: BUG #13440: unaccent does not remove all diacritics

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Léonard Benedetti <benedetti(at)mlpo(dot)fr>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13440: unaccent does not remove all diacritics
Date: 2016-03-12 04:06:03
Message-ID: 16818.1457755563@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 3/11/16 1:16 PM, Tom Lane wrote:
>> Doesn't matter. We support both Python 2 and 3, and this script must
>> do so as well, else it's not getting committed.

> This script is only run occasionally when the unaccent data needs to be
> updated from Unicode data, so it's not really that important what
> language and version it's written in.

Oh, okay, I'd supposed this would be part of the build process.

> That said, the mentioned reason
> for changing this to Python 3 is so that one can include Unicode
> characters into the source text, which I find undesirable in general
> (for PostgreSQL source code) and not very useful in this particular
> case. I think the script can be kept in Python 2 style.

Works for me, and I agree that Unicode in our source text is mostly
a pain.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message anthony 2016-03-12 10:09:50 BUG #14017: strange syntax error
Previous Message Léonard Benedetti 2016-03-12 03:44:27 Re: BUG #13440: unaccent does not remove all diacritics