| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Clear out the reminants of EXTEND INDEX |
| Date: | 2001-07-16 19:30:27 |
| Message-ID: | 16807.995311827@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>> I always rip that stuff out. We do an initdb for every release. What
>>> could break by renumbering those nodes?
>>
>> Actually, since we don't store node type numbers on disk (just symbolic
>> names), there's probably nothing that could break as long as people do a
>> full recompile when they update. It's no worse than changing the fields
>> of a widely-used struct, I suppose. I was just being paranoid.
On third thought, there is some value to preserving the node numbers:
when we see a bug report from the field like
ERROR: ExecEvalExpr: unknown expression type 108
we don't have to resort to excavating back versions of nodes.h to figure
out which node type is meant.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-07-16 20:08:49 | Re: Clear out the reminants of EXTEND INDEX |
| Previous Message | Bruce Momjian | 2001-07-16 19:16:29 | Re: Clear out the reminants of EXTEND INDEX |