Skip site navigation (1) Skip section navigation (2)

Protection lost in expression eval changeover

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Protection lost in expression eval changeover
Date: 2017-03-28 17:52:50
Message-ID: 16803.1490723570@sss.pgh.pa.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
CheckVarSlotCompatibility contains the comment

	 * Note: we allow a reference to a dropped attribute.  slot_getattr will
	 * force a NULL result in such cases.

While still true, that second sentence is now quite irrelevant, because we
don't go through slot_getattr anymore.  So it seems like we are missing
some needed protection.  I'm inclined to think that it'd be all right to
just throw an error immediately in CheckVarSlotCompatibility if the
target column is dropped.

			regards, tom lane


Responses

pgsql-hackers by date

Next:From: David SteeleDate: 2017-03-28 17:57:53
Subject: Re: Supporting huge pages on Windows
Previous:From: Mark DilgerDate: 2017-03-28 17:52:40
Subject: Re: Monitoring roles patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group