Re: Supporting huge pages on Windows

From: David Steele <david(at)pgmasters(dot)net>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Supporting huge pages on Windows
Date: 2017-03-28 17:57:53
Message-ID: 019dfac7-8f4d-2ae2-735a-df36355f8fd2@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/24/17 12:51 PM, Ashutosh Sharma wrote:
> Hi,
>
> On Fri, Mar 24, 2017 at 9:00 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>> Hi Ashutosh,
>>
>> On 3/22/17 8:52 AM, Amit Kapila wrote:
>>>
>>> On Wed, Mar 22, 2017 at 12:07 AM, David Steele <david(at)pgmasters(dot)net>
>>> wrote:
>>>>
>>>>
>>>> Amit, Magnus, you are signed up as reviewers for this patch. Do you know
>>>> when you'll have a chance to take a look?
>>>>
>>>
>>> I have provided my feedback and I could not test it on my machine. I
>>> think Ashutosh Sharma has tested it. I can give it another look, but
>>> not sure if it helps.
>>
>>
>> I know you are not signed up as a reviewer, but have you take a look at this
>> patch?
>
> Well, I had a quick look into the patch just because I wanted the test
> it as I am having windows setup. But, I never looked into the patch
> from reviewer's perspective. The intention was to reverify the test
> results shared by Tsunawaka.

Thanks, Ashutosh.

It's not clear to me what state this patch should be in. Is there more
review that needs to be done or is it ready for a committer?

--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2017-03-28 17:58:54 Re: Monitoring roles patch
Previous Message Tom Lane 2017-03-28 17:52:50 Protection lost in expression eval changeover