| From: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: GUC for temporarily disabling event triggers |
| Date: | 2023-03-07 15:02:17 |
| Message-ID: | 167820133729.628976.13138108812993260186.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
I like it now.
* The patch does what it intends to do;
* The implementation way is clear;
* All test are passed;
* No additional problems catched - at least by my eyes;
I think it can be marked as Ready for Committer
N.B. In fact I've encountered couple of failed tests during installcheck-world, although the same fails are there even for master branch. Thus doesn't seem to be this patch issue.
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-03-07 15:10:07 | Re: Add shared buffer hits to pg_stat_io |
| Previous Message | Andrew Dunstan | 2023-03-07 14:32:40 | Re: Add a hook to allow modification of the ldapbindpasswd |