Re: Inconsistency in plpgsql's error context reports

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Inconsistency in plpgsql's error context reports
Date: 2017-12-11 17:46:22
Message-ID: 16763.1513014382@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Dec 10, 2017 at 11:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> There seem to be two ways we could look at this. One is that the
>> new test case just needs to be rejiggered to avoid unstable output
>> ("\set VERBOSITY terse" would be the easiest way). But there is
>> also room to argue that it's bad that plpgsql produces error reports
>> that vary depending on the phase of the moon, which is pretty much
>> what this would look like in the field --- cache flushes will occur
>> unpredictably in most application environments.

> I am inclined toward the latter view.

Yeah, me too. I'll see about patching exec_eval_simple_expr() to
provide a context line that matches SPI's. Seems like a HEAD-only
change though, as this will result in visible behavior change in
the typical case.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-11 17:52:24 Re: Mention ordered datums in PartitionBoundInfoData comment
Previous Message Robert Haas 2017-12-11 17:46:20 Re: [HACKERS] Custom compression methods