Re: Arbitary file size limit in twophase.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "Gavin Sherry" <swm(at)alcove(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Arbitary file size limit in twophase.c
Date: 2008-05-16 14:26:28
Message-ID: 16728.1210947988@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> Tom Lane wrote:
>> It might be worth checking at prepare that the file size doesn't exceed
>> MaxAllocSize, but any smaller limit strikes me as (a) unnecessarily
>> restrictive and (b) not actually creating any useful guarantee.

> Patch attached. I can't commit it myself right now, but will do so as
> soon as I can, unless there's objections.

Two bugs: "exceeed" -> "exceeded", please; and on the read side, you
should still have an upper-bound check, but it should be MaxAllocSize.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-16 14:35:05 Re: deadlock while doing VACUUM and DROP
Previous Message Alvaro Herrera 2008-05-16 14:14:45 Re: deadlock while doing VACUUM and DROP