Re: postgres_fdw: using TABLESAMPLE to collect remote sample

From: James Finnerty <jfinnert(at)amazon(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Date: 2022-12-15 16:34:35
Message-ID: 167112207543.1120.12195641719862911275.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This patch looks good to me. I have two very minor nits: The inflation of the sample size by 10% is arbitrary but it doesn't seem unreasonable or concerning. It just makes me curious if there are any known cases that motivated adding this logic. Secondly, if the earliest non-deprecated version of PostgreSQL supports sampling, then you could optionally remove the logic that tests for that. The affected lines should be unreachable.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-12-15 16:46:56 Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Previous Message vignesh C 2022-12-15 16:24:44 Re: Support logical replication of DDLs