| From: | Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, David Rowley <dgrowley(at)gmail(dot)com> |
| Subject: | Re: Speed up transaction completion faster after many relations are accessed in a transaction |
| Date: | 2022-11-03 15:42:05 |
| Message-ID: | 166749012522.1122.11683450499316408651.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David,
This is review of speed up releasing of locks patch.
Contents & Purpose:
Subject is missing in patch. It would have been easier to understand purpose had it been included.
Included in the patch are change in README, but no new tests are included..
Initial Run:
The patch applies cleanly to HEAD. The regression tests all pass
successfully against the new patch.
Nitpicking & conclusion:
I don't see any performance improvement in tests. Lots of comments
were removed which were not fully replaced. Change of log level for ReleaseLockIfHeld: failed
from warning to panic is mystery.
Change in readme doesn't look right.
`Any subsequent lockers are share lockers wait
waiting for the VXID to terminate via some other method) is for deadlock`. This sentence could be rewritten.
Also more comments could be added to explain new methods added.
Thanks,
Ankit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-11-03 15:42:17 | Re: parse partition strategy string in gram.y |
| Previous Message | Tom Lane | 2022-11-03 15:29:04 | Re: [BUG] Logical replica crash if there was an error in a function. |