From: | pgsql(at)mohawksoft(dot)com |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Nicolai Tufar" <ntufar(at)gmail(dot)com>, "Magnus Hagander" <mha(at)sollentuna(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, "PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Re: [pgsql-hackers-win32] snprintf causes regression |
Date: | 2005-03-02 21:38:28 |
Message-ID: | 16674.24.91.171.78.1109799508.squirrel@mail.mohawksoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> Tom Lane wrote:
>>> First line of thought: we surely must not insert a snprintf into
>>> libpq.so unless it is 100% up to spec *and* has no performance issues
>>> ... neither of which can be claimed of the CVS-tip version.
>
>> Agreed, and we have to support all the 64-bit specifications a port
>> might support like %qd and %I64d as well as %lld. I have added that to
>> our current CVS version.
>
> I really dislike that idea and request that you revert it.
>
>> Is there any way we can have just gettext() call our snprintf under a
>> special name?
>
> The issue only comes up in libpq --- in the backend there is no reason
> that snprintf can't be our snprintf, and likewise in self-contained
> programs like psql. It might be worth the pain-in-the-neck quality to
> have libpq refer to the functions as pq_snprintf etc. Perhaps we could
> do this via macros
>
> #define snprintf pq_snprintf
Didn't I suggest that earlier? :) Also, since it is vsnprintf that seems
to be a bigger issue:
#define vsnprintf pq_vsnprintf
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-02 21:51:21 | Re: Vacuum time degrading |
Previous Message | Wes | 2005-03-02 21:31:12 | Re: Vacuum time degrading |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-02 22:29:48 | Re: [PERFORM] Help with tuning this query (with explain analyze finally) |
Previous Message | Ken Egervari | 2005-03-02 20:38:16 | Re: Help with tuning this query (with explain analyze finally) |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-03-02 23:57:55 | Re: snprintf improvements |
Previous Message | Tom Lane | 2005-03-02 19:59:26 | Re: typos in the docu |