Re: Decoupling our alignment assumptions about int64 and double

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Decoupling our alignment assumptions about int64 and double
Date: 2026-02-05 23:32:44
Message-ID: 1664622.1770334364@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2026-02-03 17:29:46 -0500, Tom Lane wrote:
>> If we want to re-support AIX, I think we're stuck with going back
>> to the old way of calculating MAXALIGN, and then re-instituting that
>> regression test that checked for unsafely-aligned catalog columns.
>> Bleah. Still, as long as the regression test is accurate, it seems
>> like that'd be an annoyance not a major headache.

> I am pretty unhappy about that, I think the test and rules are just about
> incomprehensible. I wonder if we ought to instead just redefine float8 to be
> be aligned to 8 bytes, leaving double alone.

I thought about that, but it seemed like there'd be nothing stopping
people from declaring a catalog column as "double" rather than
"float8" and thus falling into the trap anyway. I suppose we could
put a check for that into Catalog.pm, though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-02-05 23:42:42 Re: client_connection_check_interval default value
Previous Message Tomas Vondra 2026-02-05 23:15:27 Re: Changing the state of data checksums in a running cluster