Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

From: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet
Date: 2016-05-31 19:55:03
Message-ID: 16646180.a69D9Aee7y@home
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

В письме от 31 мая 2016 15:38:38 пользователь Robert Haas написал:

> >>> 99% of the time, you'd be right. But this is an unusual case, for the
> >>> reasons I mentioned before.
> >>
> >> I tend to agree with Nikolay. I can't see much upside in making this
> >> change. At best, nothing will break. At worst, something will break.
> >> But how do we actually come out ahead?
> >
> > We come out ahead by not having to make the documentation more confusing.
> >
> > Basically, we have the opportunity to fix an ancient mistake here at
> > very low cost. I do not think that doubling down on the mistake is
> > a better answer.
>
> I'm not convinced, but we don't have to agree on everything...
I am not convinced too. But I will not argue hard for the patch as far as my
main goal was to report inconsistency. Through the I consider Tom's proposal
quite strange...

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-05-31 19:55:53 Re: Rename max_parallel_degree?
Previous Message Robert Haas 2016-05-31 19:52:35 Re: COMMENT ON, psql and access methods