Re: Buildfarm issues on specific machines

"Jim C. Nasby" <decibel(at)decibel(dot)org> writes:
> And 7.3 is also failing, with a different error:
> ccache gcc -traditional-cpp -g -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../../src/include -I/opt/local/include -c -o printtup.o printtup.c
> In file included from /usr/include/machine/param.h:30,
> from /usr/include/sys/socket.h:67,
> from ../../../../src/include/libpq/pqcomm.h:28,
> from ../../../../src/include/libpq/libpq-be.h:24,
> from ../../../../src/include/libpq/libpq.h:21,
> from printtup.c:20:
> /usr/include/ppc/param.h:98: macro "btodb" requires 2 arguments, but only 1 given
> /usr/include/ppc/param.h:100: macro "dbtob" requires 2 arguments, but only 1 given

This has been seen before, eg
http://archives.postgresql.org/pgsql-hackers/2003-10/msg00579.php
http://archives.postgresql.org/pgsql-hackers/2003-11/msg00163.php

At the time we felt this was Apple's fault and didn't want to back-patch
any changes:
http://archives.postgresql.org/pgsql-hackers/2003-11/msg00170.php

I'm not sure I want to invest a lot of work in extracting and
back-patching the necessary changes to make pre-7.4 PG build on Apple's
recent toolchains. I think that changing -traditional-cpp to
-no-cpp-precomp in template/darwin would get you past the above-quoted
failure, but there are probably more problems waiting after that.
A quick look through the 7.4 CVS history suggests there were quite a few
fixes for Darwin, many of them done in a way with possible side-effects
on other platforms, so just back-patching would probably be out of the
question anyway.

In short, OS X > 10.2 wasn't a supported platform when 7.2/7.3 came out,
and I don't want to retroactively try to make it so.

regards, tom lane