Skip site navigation (1) Skip section navigation (2)

Re: add label to enum syntax

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add label to enum syntax
Date: 2010-10-25 17:08:38
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> It occurred to me in the dead of the night that instead of:
>     ALTER TYPE enumtype ADD 'newlabel'
> it might be better to have:
>     ALTER TYPE enumtype ADD LABEL 'newlabel'
> That way if we later wanted to support some other sort of ADD operation 
> on types we would be able to more easily.

I can see the point of that, but I don't find LABEL to be a particularly
great name for the elements of an enum type, and so I'm not in favor of
institutionalizing that name in the syntax.  How about ADD VALUE?

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Brendan JurdDate: 2010-10-25 17:20:26
Subject: Re: Segfault in 9.0 inlining SRF
Previous:From: Robert HaasDate: 2010-10-25 17:00:36
Subject: Re: Range Types, discrete and/or continuous

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group