Re: pgsql: Remove pgbench "progress" test pending solution of its timing is

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove pgbench "progress" test pending solution of its timing is
Date: 2017-09-23 18:05:51
Message-ID: 16506.1506189951@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Globally these test failures reveals pathological testing conditions: the
> inability to execute a simple select over several seconds. It could have
> been OOM or whatever else.

Well, I think it's mostly about valgrind making everything really slow.
Since we have seen some passes from skink recently, perhaps there was also
a component of more-load-on-the-machine-than-usual. But in the end this
is just evidence for my point that regression tests have to be very much
not timing-sensitive. We run them under all kinds of out-of-the-ordinary
stress.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-23 19:02:04 pgsql: Fix bogus size calculation in strlist_to_textarray().
Previous Message Andres Freund 2017-09-23 18:04:31 Re: pgsql: Remove pgbench "progress" test pending solution of its timing is