From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: valgrind error |
Date: | 2020-06-06 03:03:24 |
Message-ID: | 1647550.1591412604@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Fri, Jun 05, 2020 at 12:17:54PM -0400, Tom Lane wrote:
>> as you have it, I'd prefer to use
>> - fun:pg_comp_crc32c
>> + fun:pg_comp_crc32c_sb8
>> which precisely matches what 4f700bc did. The other way seems like
>> it's giving a free pass to problems that could lurk in unrelated CRC
>> implementations.
> The undefined data is in the CRC input, namely the padding bytes in xl_*
> structs.
Oh, I see. Objection withdrawn.
> Apparently, valgrind-3.15.0 doesn't complain about undefined input
> to _mm_crc32_u* functions. We should not be surprised if Valgrind gains the
> features necessary to complain about the other implementations.
Perhaps it already has ... I wonder if anyone's tried this on ARMv8
lately.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-06-06 03:32:32 | Re: Atomic operations within spinlocks |
Previous Message | Noah Misch | 2020-06-06 02:57:28 | Re: valgrind error |