Re: BUG #2685: Wrong charset of server messages on client [PATCH]

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Sergiy Vyshnevetskiy" <serg(at)vostok(dot)net>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #2685: Wrong charset of server messages on client [PATCH]
Date: 2006-10-10 15:37:14
Message-ID: 16461.1160494634@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"Sergiy Vyshnevetskiy" <serg(at)vostok(dot)net> writes:
> Convert server messages to database charset.

This has been discussed before:
http://archives.postgresql.org/pgsql-patches/2005-08/msg00245.php

The magic pg_enc2iananame_tbl[] you reference in your patch does not exist,
and if it did exist it wouldn't work on all platforms, since encoding
names aren't sufficiently well standardized :-(

> This, however, uncovers another bug: PostgreSQL dumps the messages into
> stderr/syslog as-is, without converting database data from database charset
> to charset from LC_MESSAGES.

I'm quite unconvinced that that's a bug. If we tried to do a conversion
here, it would be trivial to set up denials of service for logging ---
just include a character in a comment in your SQL command that cannot be
converted to the LC_MESSAGES character set.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2006-10-10 15:50:36 Re: BUG #2684: Memory leak in libpq
Previous Message Milen A. Radev 2006-10-10 15:30:43 Re: BUG #2684: Memory leak in libpq