Re: psql \df choose functions by their arguments

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql \df choose functions by their arguments
Date: 2021-04-07 19:57:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Greg Sabino Mullane <htamfids(at)gmail(dot)com> writes:
> [ v6-psql-df-pick-function-by-type.patch ]

I looked this over. I like the idea a lot, but not much of anything
about the implementation. I think the additional arguments should be
matched to the function types using the same rules as for \dT. That
allows patterns for the argument type names, which is particularly
useful if you want to do something like
\df foo * integer
to find functions whose second argument is integer, without restricting
the first argument.

As a lesser quibble, splitting the arguments with strtokx is a hack;
we should let the normal psql scanner collect the arguments.

So that leads me to the attached, which I think is committable. Since
we're down to the last day of the CF, I'm going to push this shortly if
there aren't squawks soon.

regards, tom lane

Attachment Content-Type Size
v7-psql-df-pick-function-by-type.patch text/x-diff 15.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-04-07 20:02:38 Re: buildfarm instance bichir stuck
Previous Message Peter Eisentraut 2021-04-07 19:55:40 Re: SQL-standard function body