Re: null iv parameter passed to combo_init()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: null iv parameter passed to combo_init()
Date: 2022-01-09 07:32:33
Message-ID: 1643134.1641713553@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On further thought, I would write it this way:

> - else
> + else if (ivlen != 0)
> memcpy(ivbuf, iv, ivlen);

FWIW, I liked the "ivlen > 0" formulation better. They should be
equivalent, because ivlen is unsigned, but it just seems like "> 0"
is more natural.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2022-01-09 11:00:00 Re: Why is src/test/modules/committs/t/002_standby.pl flaky?
Previous Message Zhihong Yu 2022-01-09 03:31:04 Re: null iv parameter passed to combo_init()