Re: Compiling C++ extensions on MSVC using scripts in src/tools

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Compiling C++ extensions on MSVC using scripts in src/tools
Date: 2014-11-26 16:40:09
Message-ID: 16430.1417020009@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> This doesn't seem to me to be terribly well expressed (I know it's not your fault, quite possibly it's mine.) Perhaps we should replace
> [r]?[cyl](pp)?
> with
> (c|cpp|y|l|rc)

+1 ... the original coding is illegible already, not to mention wrong
since it will match stuff it shouldn't.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Geoff Montee 2014-11-26 16:46:11 Re: [pgsql-packagers] Palle Girgensohn's ICU patch
Previous Message Andrew Dunstan 2014-11-26 16:25:31 Re: Compiling C++ extensions on MSVC using scripts in src/tools