| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> |
| Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres crash on CURSORS |
| Date: | 2000-04-05 04:04:07 |
| Message-ID: | 16330.954907447@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
>>>> which are executed without having bothered to check for aborted state.
>>>> I think this code should be removed from postgres.c, and the
>>>> SetQuerySnapshot call instead made from the Fetch and Copy arms of the
>>>> switch statement in ProcessUtility() (utility.c), after doing
>>>> CHECK_IF_ABORTED in each case.
> Is it bad to check ABORTED after yyparse() in parser.c ?
Yes. Try to execute an END (a/k/a ABORT, ROLLBACK, ...)
The check for abort state has to happen in the appropriate paths of
execution, not in the parser. Not all statements should reject on
abort state.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adriaan Joubert | 2000-04-05 05:31:33 | Re: 7.0 FK trigger question |
| Previous Message | Hiroshi Inoue | 2000-04-05 04:02:06 | RE: postgres crash on CURSORS |