Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-09 21:51:30
Message-ID: 16328.1578606690@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> I think he means something like
>> make check with_readline=no
>> not for the actual build.

> Oh, I see. I'd rather not codify that though, because it risks
> problems if that symbol ever gets used any other way. I was
> thinking of making the test script check for some independent
> environment variable, say SKIP_READLINE_TESTS.

I thought of another problem with the with_readline=no method,
which is that it requires the user to be issuing "make check"
directly; it wouldn't be convenient for a buildfarm owner, say.
(*Perhaps* it'd work to set with_readline=no throughout a
buildfarm run, but I think that's asking for trouble with the
build part.) I pushed a patch using SKIP_READLINE_TESTS.
Christoph should be able to set that for the Ubuntu branches
where the test is failing.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-01-09 23:48:50 Re: pgsql: tableam: New callback relation_fetch_toast_slice.
Previous Message Tom Lane 2020-01-09 21:47:17 pgsql: Skip tab-completion tests if envar SKIP_READLINE_TESTS is define

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-01-09 22:00:59 Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings
Previous Message Andrew Dunstan 2020-01-09 21:38:42 Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings