Re: WIP: System Versioned Temporal Table

Hi,

quick note: The documentation for this patch mentions:

The <literal>starttime</literal> column
+ will be automatically added to the Primary Key of the table.

A quick tests shows that the endtime column is added instead:

postgres=# create table t1 ( a int primary key generated always as identity, b text ) with system versioning;
CREATE TABLE
postgres=# \d t1
Table "public.t1"
Column | Type | Collation | Nullable | Default
-----------+--------------------------+-----------+----------+-------------------------------
a | integer | | not null | generated always as identity
b | text | | |
starttime | timestamp with time zone | | not null | generated always as row start
endtime | timestamp with time zone | | not null | generated always as row end
Indexes:
"t1_pkey" PRIMARY KEY, btree (a, endtime)

Regards
Daniel