Re[5]: On login trigger: take three

From: Ivan Panchenko <wao(at)mail(dot)ru>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re[5]: On login trigger: take three
Date: 2021-08-16 15:11:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Greg,
>Среда, 7 июля 2021, 3:55 +03:00 от Greg Nancarrow <gregn4422(at)gmail(dot)com>:

>On Sun, Jul 4, 2021 at 1:21 PM vignesh C < vignesh21(at)gmail(dot)com > wrote:
>> CFBot shows the following failure:
>> # poll_query_until timed out executing this query:
>> # SELECT '0/3046250' <= replay_lsn AND state = 'streaming' FROM
>> pg_catalog.pg_stat_replication WHERE application_name = 'standby_1';
>> # expecting this output:
>> # t
>> # last actual query output:
>> # t
>> # with stderr:
>> # NOTICE: You are welcome!
>> # Looks like your test exited with 29 before it could output anything.
>> t/ ..................
>> Dubious, test returned 29 (wstat 7424, 0x1d00)
>I found that the patch was broken by commit f452aaf7d (the part
>"adjust poll_query_until to insist on empty stderr as well as a stdout
>So I had to remove a "RAISE NOTICE" (which was just an informational
>message) from the login trigger function, to satisfy the new
>poll_query_until expectations.

Does it mean that "RAISE NOTICE" should’t be used, or behaves unexpectedly in logon triggers? Should we mention this in the docs?
Ivan Panchenko
>Also, I updated a PG14 version check (now must check PG15 version).
>Greg Nancarrow
>Fujitsu Australia

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2021-08-16 15:24:33 Re: badly calculated width of emoji in psql
Previous Message Ranier Vilela 2021-08-16 15:04:54 Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode